Reworking sixel implementation based on veltza's implementation (#117)
* sixel: remove black bars from sixel images When the images don't fully cover the text cells, black bars are added to them. This fix removes those bars, but if you need the old behavior, you can restore it by setting 'sixelremovebars' to zero in config.h * sixel: fix a potential memory leak * sixel: improve behavior with text reflow * sixel: prevent animated gifs from choking the terminal Animated gifs constantly spawn new images that eventually choke the terminal because the old animation frames are kept in the image buffer. This fix removes overlapping images from the image buffer and prevents them from piling up. * sixel: add zooming and clipping * sixel: copying bulk of changes * sixel: move sixel_parser_parse() and add missing sequences and blocks (#113) - Move sixel_parser_parse() from tputc() to twrite() - Add missing 8452, DECSDM, XTSMGRAPHICS and XTWINOPS sequences - Add more conditional blocks for the scrollback and sync patches - Remove unused reflow_y from ImageList. It is only used for the scrollback-reflow patch in st-sx. * sixel: update vtiden to VT200 family * sixel: fix scrolling issues inside tmux (#114) tmux is using the scrolling region and sequence to clear the screen below the shell prompt. This peculiar behavior caused the tscrollup() function to be called, which always scrolled the images regardless of whether they were inside the region or not. So the images moved out of place whenever the bottom of the screen was cleared. This fix checks that the images are inside the region before scrolling them. * sixel: prevent images from being deleted when resizing (#115) This fixes resizing issues outside of tmux not inside. * Rewriting tresize logic based on veltza's proposed implementation in PR #115 * tresize: correction for tscrollup call when scrollback patch is used --------- Co-authored-by: veltza <106755522+veltza@users.noreply.github.com>
This commit is contained in:
Stein Gunnar Bakkeby
GitHub
parent
2e0e84d56a
commit
677c2da0be
13 changed files with 790 additions and 321 deletions
148
x.c
148
x.c
|
|
@ -27,6 +27,11 @@ char *argv0;
|
|||
#include <X11/Xcursor/Xcursor.h>
|
||||
#endif // THEMED_CURSOR_PATCH
|
||||
|
||||
#if SIXEL_PATCH
|
||||
#include <Imlib2.h>
|
||||
#include "sixel.h"
|
||||
#endif // SIXEL_PATCH
|
||||
|
||||
#if UNDERCURL_PATCH
|
||||
/* Undercurl slope types */
|
||||
enum undercurl_slope_type {
|
||||
|
|
@ -282,17 +287,36 @@ zoom(const Arg *arg)
|
|||
Arg larg;
|
||||
|
||||
larg.f = usedfontsize + arg->f;
|
||||
#if SIXEL_PATCH
|
||||
if (larg.f >= 1.0)
|
||||
zoomabs(&larg);
|
||||
#else
|
||||
zoomabs(&larg);
|
||||
#endif // SIXEL_PATCH
|
||||
}
|
||||
|
||||
void
|
||||
zoomabs(const Arg *arg)
|
||||
{
|
||||
#if SIXEL_PATCH
|
||||
ImageList *im;
|
||||
#endif // SIXEL_PATCH
|
||||
|
||||
xunloadfonts();
|
||||
xloadfonts(usedfont, arg->f);
|
||||
#if FONT2_PATCH
|
||||
xloadsparefonts();
|
||||
#endif // FONT2_PATCH
|
||||
|
||||
#if SIXEL_PATCH
|
||||
/* deleting old pixmaps forces the new scaled pixmaps to be created */
|
||||
for (im = term.images; im; im = im->next) {
|
||||
if (im->pixmap)
|
||||
XFreePixmap(xw.dpy, (Drawable)im->pixmap);
|
||||
im->pixmap = NULL;
|
||||
}
|
||||
#endif // SIXEL_PATCH
|
||||
|
||||
cresize(0, 0);
|
||||
redraw();
|
||||
xhints();
|
||||
|
|
@ -850,7 +874,7 @@ cresize(int width, int height)
|
|||
|
||||
col = (win.w - 2 * borderpx) / win.cw;
|
||||
row = (win.h - 2 * borderpx) / win.ch;
|
||||
col = MAX(1, col);
|
||||
col = MAX(2, col);
|
||||
row = MAX(1, row);
|
||||
|
||||
#if ANYSIZE_PATCH
|
||||
|
|
@ -2981,71 +3005,121 @@ xfinishdraw(void)
|
|||
{
|
||||
#if SIXEL_PATCH
|
||||
ImageList *im, *next;
|
||||
Imlib_Image origin, scaled;
|
||||
XGCValues gcvalues;
|
||||
GC gc;
|
||||
int width, height;
|
||||
int x, x2, del;
|
||||
Line line;
|
||||
#endif // SIXEL_PATCH
|
||||
|
||||
#if SIXEL_PATCH
|
||||
for (im = term.images; im; im = next) {
|
||||
/* get the next image here, because delete_image() will delete the current image */
|
||||
next = im->next;
|
||||
|
||||
if (im->should_delete) {
|
||||
delete_image(im);
|
||||
/* do not draw or process the image, if it is not visible */
|
||||
if (im->x >= term.col || im->y >= term.row || im->y < 0)
|
||||
continue;
|
||||
}
|
||||
|
||||
/* scale the image */
|
||||
width = im->width * win.cw / im->cw;
|
||||
height = im->height * win.ch / im->ch;
|
||||
if (!im->pixmap) {
|
||||
im->pixmap = (void *)XCreatePixmap(xw.dpy, xw.win, im->width, im->height,
|
||||
im->pixmap = (void *)XCreatePixmap(xw.dpy, xw.win, width, height,
|
||||
#if ALPHA_PATCH
|
||||
xw.depth
|
||||
#else
|
||||
DefaultDepth(xw.dpy, xw.scr)
|
||||
#endif // ALPHA_PATCH
|
||||
);
|
||||
XImage ximage = {
|
||||
.format = ZPixmap,
|
||||
.data = (char *)im->pixels,
|
||||
.width = im->width,
|
||||
.height = im->height,
|
||||
.xoffset = 0,
|
||||
.byte_order = LSBFirst,
|
||||
.bitmap_bit_order = MSBFirst,
|
||||
.bits_per_pixel = 32,
|
||||
.bytes_per_line = im->width * 4,
|
||||
.bitmap_unit = 32,
|
||||
.bitmap_pad = 32,
|
||||
#if ALPHA_PATCH
|
||||
.depth = xw.depth
|
||||
#else
|
||||
.depth = 24
|
||||
#endif // ALPHA_PATCH
|
||||
};
|
||||
XPutImage(xw.dpy, (Drawable)im->pixmap, dc.gc, &ximage, 0, 0, 0, 0, im->width, im->height);
|
||||
free(im->pixels);
|
||||
im->pixels = NULL;
|
||||
if (win.cw == im->cw && win.ch == im->ch) {
|
||||
XImage ximage = {
|
||||
.format = ZPixmap,
|
||||
.data = (char *)im->pixels,
|
||||
.width = im->width,
|
||||
.height = im->height,
|
||||
.xoffset = 0,
|
||||
.byte_order = sixelbyteorder,
|
||||
.bitmap_bit_order = MSBFirst,
|
||||
.bits_per_pixel = 32,
|
||||
.bytes_per_line = im->width * 4,
|
||||
.bitmap_unit = 32,
|
||||
.bitmap_pad = 32,
|
||||
#if ALPHA_PATCH
|
||||
.depth = xw.depth
|
||||
#else
|
||||
.depth = 24
|
||||
#endif // ALPHA_PATCH
|
||||
};
|
||||
XPutImage(xw.dpy, (Drawable)im->pixmap, dc.gc, &ximage, 0, 0, 0, 0, width, height);
|
||||
} else {
|
||||
origin = imlib_create_image_using_data(im->width, im->height, (DATA32 *)im->pixels);
|
||||
if (!origin)
|
||||
continue;
|
||||
imlib_context_set_image(origin);
|
||||
imlib_image_set_has_alpha(1);
|
||||
scaled = imlib_create_cropped_scaled_image(0, 0, im->width, im->height, width, height);
|
||||
imlib_free_image_and_decache();
|
||||
if (!scaled)
|
||||
continue;
|
||||
imlib_context_set_image(scaled);
|
||||
imlib_image_set_has_alpha(1);
|
||||
XImage ximage = {
|
||||
.format = ZPixmap,
|
||||
.data = (char *)imlib_image_get_data_for_reading_only(),
|
||||
.width = width,
|
||||
.height = height,
|
||||
.xoffset = 0,
|
||||
.byte_order = sixelbyteorder,
|
||||
.bitmap_bit_order = MSBFirst,
|
||||
.bits_per_pixel = 32,
|
||||
.bytes_per_line = width * 4,
|
||||
.bitmap_unit = 32,
|
||||
.bitmap_pad = 32,
|
||||
#if ALPHA_PATCH
|
||||
.depth = xw.depth
|
||||
#else
|
||||
.depth = 24
|
||||
#endif // ALPHA_PATCH
|
||||
};
|
||||
XPutImage(xw.dpy, (Drawable)im->pixmap, dc.gc, &ximage, 0, 0, 0, 0, width, height);
|
||||
imlib_free_image_and_decache();
|
||||
}
|
||||
}
|
||||
|
||||
/* clip the image so it does not go over to borders */
|
||||
x2 = MIN(im->x + im->cols, term.col);
|
||||
width = MIN(width, (x2 - im->x) * win.cw);
|
||||
|
||||
/* delete the image if the text cells behind it have been changed */
|
||||
#if SCROLLBACK_PATCH
|
||||
line = TLINE(im->y);
|
||||
#else
|
||||
line = term.line[im->y];
|
||||
#endif // SCROLLBACK_PATCH
|
||||
for (del = 0, x = im->x; x < x2; x++) {
|
||||
if ((del = !(line[x].mode & ATTR_SIXEL)))
|
||||
break;
|
||||
}
|
||||
if (del) {
|
||||
delete_image(im);
|
||||
continue;
|
||||
}
|
||||
|
||||
/* draw the image */
|
||||
memset(&gcvalues, 0, sizeof(gcvalues));
|
||||
gcvalues.graphics_exposures = False;
|
||||
gc = XCreateGC(xw.dpy, xw.win, GCGraphicsExposures, &gcvalues);
|
||||
|
||||
#if ANYSIZE_PATCH
|
||||
XCopyArea(xw.dpy, (Drawable)im->pixmap, xw.buf, gc, 0, 0, im->width, im->height, win.hborderpx + im->x * win.cw, win.vborderpx + im->y * win.ch);
|
||||
#else
|
||||
XCopyArea(xw.dpy, (Drawable)im->pixmap, xw.buf, gc, 0, 0, im->width, im->height, borderpx + im->x * win.cw, borderpx + im->y * win.ch);
|
||||
#endif // ANYSIZE_PATCH
|
||||
XCopyArea(xw.dpy, (Drawable)im->pixmap, xw.buf, gc, 0, 0,
|
||||
width, height, borderpx + im->x * win.cw, borderpx + im->y * win.ch);
|
||||
XFreeGC(xw.dpy, gc);
|
||||
|
||||
}
|
||||
#endif // SIXEL_PATCH
|
||||
|
||||
#if !SINGLE_DRAWABLE_BUFFER_PATCH
|
||||
XCopyArea(xw.dpy, xw.buf, xw.win, dc.gc, 0, 0, win.w, win.h, 0, 0);
|
||||
#endif // SINGLE_DRAWABLE_BUFFER_PATCH
|
||||
XSetForeground(xw.dpy, dc.gc,
|
||||
dc.col[IS_SET(MODE_REVERSE)?
|
||||
defaultfg : defaultbg].pixel);
|
||||
XSetForeground(xw.dpy, dc.gc, dc.col[IS_SET(MODE_REVERSE) ? defaultfg : defaultbg].pixel);
|
||||
}
|
||||
|
||||
void
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue