Removing the VIM browse patch.

The general reasoning is that the vim browse patch is very invasive,
has a high level of complexity, and is incompatible with a significant
number of other patches and it complicates further maintenance.

Additionally the patch has its own scrollback mechanism which seemingly
did not work properly - and nobody seems to have complained about this
since the patch was added back in May 2021.

If you want to try out the vim browse patch then I would recommend having
a play around with the patch author's own build that has this patch
integrated:
   - https://github.com/juliusHuelsmann/st-history-vim
   - https://github.com/juliusHuelsmann/st

Alternatively a tag has been added to this repository that refers to the
last commit that still has the vim browse patch:
   - https://github.com/bakkeby/st-flexipatch/tree/VIM_BROWSE_PATCH
This commit is contained in:
Bakkeby 2024-03-07 22:35:11 +01:00
parent 340caa5d0a
commit e88f2bf20c
13 changed files with 40 additions and 938 deletions

View file

@ -1,4 +1,4 @@
Similar to [dwm-flexipatch](https://github.com/bakkeby/dwm-flexipatch) this st 0.9 (a3f74203, 2024-02-18) project has a different take on st patching. It uses preprocessor directives to decide whether or not to include a patch during build time. Essentially this means that this build, for better or worse, contains both the patched _and_ the original code. The aim being that you can select which patches to include and the build will contain that code and nothing more.
Similar to [dwm-flexipatch](https://github.com/bakkeby/dwm-flexipatch) this st 0.9 (95f22c5, 2024-03-04) project has a different take on st patching. It uses preprocessor directives to decide whether or not to include a patch during build time. Essentially this means that this build, for better or worse, contains both the patched _and_ the original code. The aim being that you can select which patches to include and the build will contain that code and nothing more.
For example to include the `alpha` patch then you would only need to flip this setting from 0 to 1 in [patches.h](https://github.com/bakkeby/st-flexipatch/blob/master/patches.def.h):
```c
@ -15,6 +15,8 @@ Refer to [https://st.suckless.org/](https://st.suckless.org/) for details on the
### Changelog:
2024-03-07 - Improved sixel support, removed VIM browse patch
2022-10-24 - Added the fullscreen patch
2022-08-28 - Added the use XftFontMatch patch
@ -278,11 +280,16 @@ Refer to [https://st.suckless.org/](https://st.suckless.org/) for details on the
- [vertcenter](https://st.suckless.org/patches/vertcenter/)
- vertically center lines in the space available if you have set a larger chscale in config.h
- [vim-browse](https://st.suckless.org/patches/vim_browse/)
- the vim-browse patch offers the possibility to move through the terminal history-buffer,
search for strings using VIM-like motions, operations and quantifiers
- it overlays the screen with highlighted search results and displays the current operation
/ motions / search string in the bottom right corner
- [~vim-browse~](https://st.suckless.org/patches/vim_browse/)
- ~the vim-browse patch offers the possibility to move through the terminal history-buffer,~
~search for strings using VIM-like motions, operations and quantifiers~
- ~it overlays the screen with highlighted search results and displays the current operation~
~/ motions / search string in the bottom right corner~
- the VIM browse patch was removed due to sheer complexity and it being incompatible with a
significant number of other patches
- if you want to try this patch out then the recommendation is to play around with the
author's own build of st where this is properly implemented with history buffer (scrollback)
- https://github.com/juliusHuelsmann/st
- [visualbell](https://st.suckless.org/patches/visualbell/)
- adds visual indicators for the terminal bell event